Skip to content

Commit 86af60a

Browse files
authored
fix: Added missing type (feast-dev#4315)
Added missing type Signed-off-by: Daniele Martinoli <86618610+dmartinol@users.noreply.github.com>
1 parent 21deec8 commit 86af60a

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

sdk/python/feast/diff/registry_diff.py

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
OnDemandFeatureView as OnDemandFeatureViewProto,
2121
)
2222
from feast.protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
23+
from feast.protos.feast.core.SavedDataset_pb2 import SavedDataset as SavedDatasetProto
2324
from feast.protos.feast.core.StreamFeatureView_pb2 import (
2425
StreamFeatureView as StreamFeatureViewProto,
2526
)
@@ -109,6 +110,7 @@ def tag_objects_for_keep_delete_update_add(
109110
OnDemandFeatureViewProto,
110111
StreamFeatureViewProto,
111112
ValidationReferenceProto,
113+
SavedDatasetProto,
112114
)
113115

114116

sdk/python/feast/feast_object.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@
1111
from .protos.feast.core.FeatureService_pb2 import FeatureServiceSpec
1212
from .protos.feast.core.FeatureView_pb2 import FeatureViewSpec
1313
from .protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
14+
from .protos.feast.core.SavedDataset_pb2 import SavedDatasetSpec
1415
from .protos.feast.core.StreamFeatureView_pb2 import StreamFeatureViewSpec
1516
from .protos.feast.core.ValidationProfile_pb2 import (
1617
ValidationReference as ValidationReferenceProto,
1718
)
18-
from .saved_dataset import ValidationReference
19+
from .saved_dataset import SavedDataset, ValidationReference
1920
from .stream_feature_view import StreamFeatureView
2021

2122
# Convenience type representing all Feast objects
@@ -28,6 +29,7 @@
2829
FeatureService,
2930
DataSource,
3031
ValidationReference,
32+
SavedDataset,
3133
]
3234

3335
FeastObjectSpecProto = Union[
@@ -38,4 +40,5 @@
3840
FeatureServiceSpec,
3941
DataSourceProto,
4042
ValidationReferenceProto,
43+
SavedDatasetSpec,
4144
]

0 commit comments

Comments
 (0)