Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scales v1.3 renamed "trans" class to "transform" #394

Open
CarolineFrei opened this issue Dec 5, 2023 · 1 comment
Open

Scales v1.3 renamed "trans" class to "transform" #394

CarolineFrei opened this issue Dec 5, 2023 · 1 comment

Comments

@CarolineFrei
Copy link

Describe the bug
The version 1.3 of the scales package renamed the class returned by by scales::trans_new method from transto transform: r-lib/scales@1ed7b9a

This breaks the following line in transformerList: https://github.com/RGLab/flowWorkspace/blob/a564dbb03c37349255d420427629bf6ebef00b74/R/GatingSet_Methods.R#L1108C10-L1108C10

To Reproduce
Use any script using transformerList.

This throws: Error: 'trans' must be a list of transformer objects (generated by scales::trans_new method

Expected behavior
Should work

SessionInfo:
flowWorkspace_4.14.0
scales_1.3.0

Additional context
This was discovered when using CytoML::diva_to_gatingsetand should affect many downstream functions using flowWorkspace.

@mikejiang
Copy link
Member

addressed by #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants