New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Docker image from source #4

Open

mjstealey opened this issue Mar 7, 2018 · 0 comments

Assignees

Labels

Member

mjstealey commented Mar 7, 2018

Reference to email from Martyn

Thanks for catching this.

The error you describe is an artifact of a very recent pull request, where we corrected the year for the paper describing a model decision. CM_QJRMS1998 is shorthand for Choudhury and Monteith, Quarterly Journal of the Royal Met Society, 1998). The paper was actually published in 1988 and we corrected the decision to reflect this.

Correcting the decision in the code also means that we need to correct the decision in the ancillary files (i.e., your decision in the "model decisions" file should be CM_QJRMS1988.

Moving forward:

Bart and I are almost ready for a new SUMMA release. At that point we will update all files for the test cases.

In the meantime, we can tag a version immediately before we changed the name of the model decision.

mjstealey added the enhancement label

mjstealey self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment