Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RAMClustR tool #514

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Updated RAMClustR tool #514

merged 4 commits into from
Apr 17, 2024

Conversation

zargham-ahmad
Copy link
Collaborator

@zargham-ahmad zargham-ahmad commented Apr 11, 2024

This PR includes the following:

  • Added filter blanks, filter cv, qc as part of the tool.
  • Produce additional graph output if filter cv or qc is selected.
  • added test data and test for this.

I have added the test data for the new test which is present used in the package itself as it contain qc and blanc sample

note
The CI should pass after #504 gets merged

closes #392

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galaxy wrapper version needs a bump - otherwise seems fine :)

Comment on lines +227 to +230
<param label="qc tag" name="qc_tag" type="text" value="QC"
help="Character vector of length one or two. If length is two, enter search string and factor name in $phenoData slot
(i.e. c('QC', 'sample.type'). If length one (i.e. 'QC'), will search for this string in the 'sample.names' slot by default.
Default is 'QC'"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be maybe moved to a token but I'm not sure if nested macros work.

tools/ramclustr/ramclustr.xml Outdated Show resolved Hide resolved
@hechth hechth merged commit 8775353 into RECETOX:master Apr 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAMClustR: Add filtering, qc and plots for related steps
2 participants