Galaxy wrappers for the MFAssignR functions #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Aug 8, 2024
|
Very cool @KristinaGomoryova! |
bgruening
reviewed
Aug 15, 2024
bgruening
reviewed
Aug 15, 2024
| help= "Input data frame - output from MFAssign or MFAssignCHO. Recommended are 'Unambiguous' assignments."/> | ||
| </inputs> | ||
| <outputs> | ||
| <data name="recal_series" format="tabular" label="Recalibration series by ${tool.name} on ${on_string}"/> |
There was a problem hiding this comment.
think about adding column names to your tabular files - will improve UX
There was a problem hiding this comment.
The tools are quite specific and most inputs are outputs from other tools, so I don't expect people to come with their own files. Or do you mean something else than adding the colnames to the help text?
There was a problem hiding this comment.
There was a problem hiding this comment.
This creates some very tight coupling between the package and the Galaxy tools :/
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes galaxy wrappers for all the MFAssignR functions except for the IsoFiltR function, which was solved in PR #565.
Closes #473
Closes #472
Closes #470
Closes #469