Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate/remove output.path argument from fit_CWCurve() #207

Closed
mcol opened this issue Sep 6, 2024 · 2 comments
Closed

deprecate/remove output.path argument from fit_CWCurve() #207

mcol opened this issue Sep 6, 2024 · 2 comments

Comments

@mcol
Copy link
Contributor

mcol commented Sep 6, 2024

There's this TODO note:

##TODO
##remove output.path

As now with more coverage we hit the lines where output.path is used and an output CSV file is generated, we get a note when running R CMD check:

 checking for detritus in the temp directory ... NOTE
  Found the following files/directories:
    ‘RtmpZkat2Ifit_CWCurve_Output_Default.csv’

So perhaps it's a good reason to actually remove that argument?

@mcol mcol added this to the Release version 1.0.0 milestone Sep 6, 2024
@RLumSK
Copy link
Member

RLumSK commented Sep 6, 2024

@mcol: Yes, I guess this is an ugly left-over before RLum-class object time. I suggest setting it to defunct directly and then we remove it in a version 1.x.x.

@mcol
Copy link
Contributor Author

mcol commented Sep 6, 2024

I take that you mean to remove the code altogether and for the time being throw a warning if somebody were to set the argument, but just say if you meant something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants