We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The division is misplaced, as it operates only on min(.) rather than on max(.) - min(.)
min(.)
max(.) - min(.)
Luminescence/R/calc_WodaFuchs2008.R
Lines 121 to 124 in 759a114
This can be more compactly be rewritten as diff(range(.)) / bin_width.
diff(range(.)) / bin_width
The text was updated successfully, but these errors were encountered:
OK
Sorry, something went wrong.
Example of failure as as it computes n_breaks = -15.71539 :
n_breaks = -15.71539
data(ExampleData.Fading) calc_WodaFuchs2008(ExampleData.Fading$fading.data$IR50) # Error in hist.default(x = data[, 1], breaks = n_breaks, plot = FALSE) : # invalid number of 'breaks'
Even simpler:
set.seed(1) calc_WodaFuchs2008(data.frame(rnorm(20, 10), rnorm(20, 0.5))) # Error in hist.default(x = data[, 1], breaks = n_breaks, plot = FALSE) : # invalid number of 'breaks'
Fixed by #198.
No branches or pull requests
The division is misplaced, as it operates only on
min(.)
rather than onmax(.) - min(.)
Luminescence/R/calc_WodaFuchs2008.R
Lines 121 to 124 in 759a114
This can be more compactly be rewritten as
diff(range(.)) / bin_width
.The text was updated successfully, but these errors were encountered: