From be9238e31e62a74875a408ea44d13f988c7f217b Mon Sep 17 00:00:00 2001 From: Junming Chen Date: Thu, 19 Oct 2023 08:52:50 +0800 Subject: [PATCH] Update cpp/src/arrow/compute/kernels/aggregate_basic_internal.h Co-authored-by: Antoine Pitrou --- cpp/src/arrow/compute/kernels/aggregate_basic_internal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/kernels/aggregate_basic_internal.h b/cpp/src/arrow/compute/kernels/aggregate_basic_internal.h index 63672a314d9d0..4268b44e98805 100644 --- a/cpp/src/arrow/compute/kernels/aggregate_basic_internal.h +++ b/cpp/src/arrow/compute/kernels/aggregate_basic_internal.h @@ -941,7 +941,9 @@ struct DictionaryMinMaxImpl : public ScalarAggregator { } this->has_nulls |= compacted_dict_arr.null_count() > 0; this->count += compacted_dict_arr.length() - compacted_dict_arr.null_count(); - + if (this->has_nulls && !options.skip_nulls) { + return Status::OK(); + } std::shared_ptr dict_min; std::shared_ptr dict_max; if (compacted_dict_arr.length() - compacted_dict_arr.null_count() == 1) {