Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] AudioController and AudioSectionLoopingController refactoring #9

Open
MirageJian opened this issue Feb 16, 2022 · 0 comments
Open

[react] AudioController and AudioSectionLoopingController refactoring #9

MirageJian opened this issue Feb 16, 2022 · 0 comments
Assignees
@MirageJian

Comments

@MirageJian
Copy link
Collaborator

MirageJian commented Feb 16, 2022 •
edited
Loading

In useAudioPlayer hook, the current playing HTMLAudioElement can be exposed and then used somewhere, such as AudioController and AudioSectionLoopingController.

In this case, controller components will use data from current playing HTMLAudioElement instead of from 1st element of refs: HTMLAudioElement[]

There might be some other components which can also be benefited from this refactoring
@MirageJian MirageJian self-assigned this Feb 16, 2022
@MirageJian MirageJian changed the title AudioController and AudioSectionLoopingController refactoring [react] AudioController and AudioSectionLoopingController refactoring Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MirageJian MirageJian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MirageJian