Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] Qwik does not recover from network failure #92

Closed
swoutch opened this issue Feb 22, 2023 · 2 comments
Closed

[✨] Qwik does not recover from network failure #92

swoutch opened this issue Feb 22, 2023 · 2 comments
Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation

Comments

@swoutch
Copy link

swoutch commented Feb 22, 2023

Which component is affected?

Qwik Runtime

Describe the bug

What I did:

  1. npm install
  2. npm run preview
  3. In the chrome window that opens, I go to the developer tools, under the network tab, and set throttling to offline
  4. I click on TODO demo 📝. Nothing happens
  5. I then set throttling to No throttling
  6. I click on TODO demo 📝 again. Nothing happens

What I expect:

At step 6, I expect the todo demo to load and work fine.

What actually happens:

At step 6, nothing happens.

Reproduction

https://github.com/swoutch/qwik-recover-offline

Steps to reproduce

  1. npm install
  2. npm run preview
  3. In the chrome window that opens, go to the developer tools, under the network tab, and set throttling to offline
  4. click on TODO demo 📝. Nothing happens
  5. set throttling to No throttling
  6. click on TODO demo 📝 again. Nothing happens

System Info

System:
    OS: macOS 13.0.1
    CPU: (8) arm64 Apple M1
    Memory: 162.73 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.3.0 - ~/.nvm/versions/node/v19.3.0/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v12.22.1/bin/yarn
    npm: 9.2.0 - ~/.nvm/versions/node/v19.3.0/bin/npm
  Browsers:
    Brave Browser: 110.1.48.164
    Chrome: 109.0.5414.119
    Firefox: 104.0.2
    Safari: 16.1
  npmPackages:
    @builder.io/qwik: 0.19.0 => 0.19.0 
    @builder.io/qwik-city: 0.3.0 => 0.3.0 
    undici: 5.20.0 => 5.20.0 
    vite: 4.1.2 => 4.1.2

Additional Information

I'm not sure which qwik component is responsible for that, so I chose qwik runtime randomly

@gioboa gioboa changed the title [🐞] Qwik does not recover from network failure [✨] Qwik does not recover from network failure Jun 14, 2024
@gioboa
Copy link
Member

gioboa commented Jun 14, 2024

This is an enhancement, no framework can manage this offline behaviour

@gioboa
Copy link
Member

gioboa commented Oct 14, 2024

We moved this issue to qwik-evolution repo to create a RFC discussion for this.
Here is our Qwik RFC process thanks.

@gioboa gioboa transferred this issue from QwikDev/qwik Oct 14, 2024
@github-project-automation github-project-automation bot moved this to In Progress (STAGE 2) in Qwik Evolution Oct 14, 2024
@github-actions github-actions bot added [STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation labels Oct 14, 2024
@QwikDev QwikDev locked and limited conversation to collaborators Oct 14, 2024
@gioboa gioboa converted this issue into discussion #168 Oct 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress (STAGE 2) to Released as Stable (STAGE 5) in Qwik Evolution Oct 14, 2024
@shairez shairez removed this from Qwik Evolution Oct 15, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation
Projects
None yet
Development

No branches or pull requests

2 participants