Improve vite.config.ts

[damianpumar]

What is it about?

Improve vite.config.ts

What's the motivation for this proposal?

Problems you are trying to solve:

Now the vite.config.ts has those lines that we can move into qwikVite plugin

type PkgDep = Record<string, string>;
const { dependencies = {}, devDependencies = {} } = pkg as any as {
  dependencies: PkgDep;
  devDependencies: PkgDep;
  [key: string]: unknown;
};
errorOnDuplicatesPkgDeps(devDependencies, dependencies);

Goals you are trying to achieve:

• Move this logic into qwikVite
• Improve the readability

Any other context or information you want to share:

---

Proposed Solution / Feature

What do you propose?

Refactor those lines and move into qwikVite plugin

Links / References

No response

[wmertens]

That code is there because the vite config is very configurable and not everyone wants the same things

[maiieul]

I think this code is to prevent the bugs that happen when people inadvertently install the qwik or qwik-city packages on both dependencies and devDependencies. Makes sense to me to abstract it away in qwikVite.

[damianpumar]

Hey @wmertens
I know that vite is very configurable, but my proposal is to hide this behaviour on like a callback or something like that, because the vite config now is too big...

[ianlet]

To keep it flexible it could be integrated into qwikVite with an option to opt-out { errorOnDuplicateDeps: true }.

As @maiieul mentions, if it leads to bugs with qwik when you mistakenly do it, then it seems more like a needed configuration than an optional one. To be validated of course and/or scoped to qwik dependencies only.

Maybe it's out of topic but what about enforcing dependencies are dev dependencies? I've seen people asking for help about this many times and the answer was "just move it as a devDependency".

[damianpumar]

Agree!

[maiieul]

Yes actually, it's probably a simple rule we can add to qwik eslint plugin 👀