Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration #1

Closed
Quramy opened this issue Dec 28, 2016 · 2 comments
Closed

Better integration #1

Quramy opened this issue Dec 28, 2016 · 2 comments

Comments

@Quramy
Copy link
Owner

Quramy commented Dec 28, 2016

Now I rewrite tsserver.js to override ts.createLanguageFunction . Is there a better way to integrate tsserver and angular's language-service ?

@angelozerr
Copy link

@Quramy please see https://github.com/angelozerr/tsserver-plugins I have used your idea to override createLanguageService (many thank's for this great idea!)

The advantage of tsserver-plugin are :

  • follow the same idea than the future of TypeScript (declared plugins in your tsconfig.json)
  • not rewrite tsserver.js, but concat at runtime teh before.js and the tsserver.js

Thanks again for your great idea!

@Quramy
Copy link
Owner Author

Quramy commented Feb 8, 2017

@angelozerr Thanks.
I'm looking forward to the PR microsoft/TypeScript#12231 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants