Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Upload] 3b. AABE, I send chat with its messages and notifications #1116

Closed
mamadoudicko opened this issue Sep 6, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@mamadoudicko
Copy link
Contributor

mamadoudicko commented Sep 6, 2023

Epic

#849

Functional

  1. Add a function getChatNotifications(chatId:UUID) and merge the result with get_chat_history result (sorted by datetime) with a function: mergeChatHistoryAndNotifications(chatHistory: List[ChatHistory], notifications:List[Notification]) -> List[ChatItem]

Where ChatItem is:

{
type:enum(Notification or Message),
body: ChatHistory | Notification
}
  1. Update the frontend
    a. In chat repo, update getHistory return type
    b. Temp: add a function with returns from getHistory result, ChatHistory[]

  2. On delete chat endpoint, before deleting the chat entity, remove related notifications

Schema

Tech

  • [] To-do

Tests

  • [] it ...

Validation Checks

  • Go to chat page
  • Feed your brain
  • Refresh the page to reload chat history
  • In network, check that /GET history result contains notifications with relevant statuses and messages
@mamadoudicko mamadoudicko converted this from a draft issue Sep 6, 2023
@mamadoudicko mamadoudicko changed the title [UX Upload] 3b. [UX Upload] 3b. AABE, I send chat with its messages and notifications Sep 6, 2023
@mamadoudicko
Copy link
Contributor Author

#1127

@mamadoudicko mamadoudicko moved this from Todo to To Be Validated in Quivr's Roadmap Sep 7, 2023
@lamiabnn lamiabnn moved this from To Be Validated to Done in Quivr's Roadmap Sep 7, 2023
@mamadoudicko mamadoudicko self-assigned this Sep 26, 2023
@github-actions
Copy link
Contributor

Thanks for your contributions, we'll be closing this issue as it has gone stale. Feel free to reopen if you'd like to continue the discussion.

@github-actions github-actions bot added the Stale label Oct 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant