Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#36 handle missed modal id scenario #38

Merged
merged 1 commit into from
Jun 24, 2021
Merged

#36 handle missed modal id scenario #38

merged 1 commit into from
Jun 24, 2021

Conversation

Quernest
Copy link
Owner

@Quernest Quernest commented Jun 24, 2021

Bug fixes that occur if hideModal, updateModal or destroyModal functions are called without provided modal ID in the argument.

This was linked to issues Jun 24, 2021
@Quernest Quernest self-assigned this Jun 24, 2021
@Quernest Quernest added the bug Something isn't working label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #38 (d8cd1fd) into master (f7fb99b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          114       129   +15     
  Branches        16        20    +4     
=========================================
+ Hits           114       129   +15     
Impacted Files Coverage Δ
src/ModalProvider.tsx 100.00% <100.00%> (ø)
src/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fb99b...d8cd1fd. Read the comment docs.

@Quernest Quernest merged commit c1535f2 into master Jun 24, 2021
@Quernest Quernest deleted the #36 branch June 24, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled missed modal ID scenario Nested dialog bug
1 participant