Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUI Dialog API changed #41

Closed
dantman opened this issue Jul 8, 2021 · 2 comments · Fixed by #43
Closed

MUI Dialog API changed #41

dantman opened this issue Jul 8, 2021 · 2 comments · Fixed by #43

Comments

@dantman
Copy link

dantman commented Jul 8, 2021

Material UI v4.12.0 and v5 have changed the Dialog API from taking onExited to instead taking a TransitionProps object with onExited in it.
@dantman
Copy link
Author

dantman commented Jul 23, 2021

Perhaps a good solution would be making the onExited handling something that can be controlled by the provider. Then you can override the current version to work with MUIv5. And a future release could switch the default to MUIv5 but still allow overriding for compatibility with MUIv4. And it'll make it work with other dialog systems too.

@Quernest
Copy link
Owner

Perhaps a good solution would be making the onExited handling something that can be controlled by the provider. Then you can override the current version to work with MUIv5. And a future release could switch the default to MUIv5 but still allow overriding for compatibility with MUIv4. And it'll make it work with other dialog systems too.

Yes, thanks, I will do it when I have free time :)

dantman added a commit to dantman/mui-modal-provider that referenced this issue Jul 24, 2021
@dantman
Allow model rendering to be overridden
5a44695 
Partially fixes Quernest#41
@dantman dantman mentioned this issue Jul 24, 2021
Closed
Quernest added a commit that referenced this issue Jul 24, 2021
@Quernest
#41 basic mui v5 migration
cfef044
Quernest added a commit that referenced this issue Jul 24, 2021
@Quernest
#41 fixed lint
ac8e6d8
@Quernest Quernest linked a pull request Jul 24, 2021 that will close this issue
♻️ #41 mui v5 migration #43
Merged
Quernest added a commit that referenced this issue Jul 25, 2021
@Quernest
#41 tests
9141dab
Quernest added a commit that referenced this issue Jul 26, 2021
@Quernest
#41 fix
1408c4a
Quernest added a commit that referenced this issue Aug 12, 2021
@Quernest
#41 updated example, beta (v5) flag
9fc85c5
Quernest added a commit that referenced this issue Aug 12, 2021
@Quernest
#41 doc
db81f14
Quernest added a commit that referenced this issue Aug 12, 2021
@Quernest
#41 doc, updated version
efe99dd
Quernest added a commit that referenced this issue Aug 12, 2021
@Quernest
#41 removed comment
573594d
Quernest added a commit that referenced this issue Aug 12, 2021
@Quernest
Merge pull request #43 from Quernest/#41
11828cd 
♻️ #41 mui v5 migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dantman @Quernest