Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upside down text for mirrored transformer #911

Open
Vort opened this issue Feb 11, 2019 · 4 comments
Open

Upside down text for mirrored transformer #911

Vort opened this issue Feb 11, 2019 · 4 comments

Comments

@Vort
Copy link
Contributor

Vort commented Feb 11, 2019

  1. Place Symmetric Transformer.
  2. Mirror it with Ctrl+M.
  3. Save schematic.
  4. Close schematic.
  5. Open schematic again.

T1 and T2 labels becomes upside down.

qucs_bug

Tested with QUCS 0.0.20 (4205dd3) on Windows 7 SP1 x64.

@Rmano
Copy link
Contributor

Rmano commented Feb 11, 2019

Happens the same in Linux; confirmed to be not Windows-specific.

@in3otd
Copy link
Contributor

in3otd commented Feb 13, 2019

I've checked the past Qucs releases and this issue has been there since quite some time, the oldest I tried was 0.0.15 and it behaves the same.

@ddrake
Copy link

ddrake commented Aug 26, 2021

I'm seeing the same issue also on Ubuntu 20.04 for the following components in Qucs 0.0.20:
Transformer, Mutual inductors, 3 mutual inductors, AM modulated source, PM modulated source, 2Bit Full Adder, RS-FlipFlop, 4 to 16 Demux, etc... (some of these may rarely need to be mirrored).

I noticed that MultiViewComponents like Microstrip Tee don't have this issue. As a test, I changed the Symmetric Transformer to derive from MultiViewComponent instead of Component (this required moving the symbol drawing code into a protected method createSymbol). That fixed the issue in this case. I've just started looking at the source code, and I'm not sure if this makes sense as a permanent fix, but maybe gives a clue to where the issue lies.

@felix-salfelder
Copy link
Member

Now that we have moved past Qt3/4 it might make sense to refactor symbols and de-duplicate code. It seems that several symbols implement coordinates, drawing, geometry, text in different ways. :(

MultiViewComponent must be renamed to reflect its purpose (if any), or removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants