Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize to dotnet archive compression libraries #2435

Closed
3 tasks done
jaredbroad opened this issue Aug 22, 2018 · 2 comments
Closed
3 tasks done

Standardize to dotnet archive compression libraries #2435

jaredbroad opened this issue Aug 22, 2018 · 2 comments

Comments

@jaredbroad
Copy link
Member

Expected Behavior

A single clean interface for working with archives

Actual Behavior

Many different libraries are used in LEAN for various Compression methods; all of them copying to memory instead of streaming due to mono issues.

Potential Solution

Careful/thoughtful testing and exploration of an archive abstraction, similar to presented here (#2416). Ideally with focus on the application and hiding the library implementation.

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
@jaredbroad jaredbroad changed the title Abstract and clean up archive libraries opening and caching Standardize to dotnet archive compression libraries Feb 17, 2023
@Martin-Molinero
Copy link
Member

Believe we need this issue to be solved dotnet/runtime#1544

@AlexCatarino AlexCatarino self-assigned this Jan 10, 2024
@Martin-Molinero
Copy link
Member

We are currently using 2 libraries because the backend is using an append functionality to existing zip entries which did not work correctly using a single library.
Since there's no real driver for this issue except code cleanness and it's risky we will skip it for now until dotnet compression is ready for our use cases.

@Martin-Molinero Martin-Molinero closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants