Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of focus ring aberrations #49

Open
7 of 9 tasks
gabalafou opened this issue Nov 15, 2023 · 1 comment
Open
7 of 9 tasks

List of focus ring aberrations #49

gabalafou opened this issue Nov 15, 2023 · 1 comment
Assignees
Labels
type: task 📌 A concrete, well-scoped item

Comments

@gabalafou
Copy link
Contributor

gabalafou commented Nov 15, 2023

Summary

While working on pydata/pydata-sphinx-theme#1549, I created a list of focus ring TODOs. I'm creating this issue to make sure that they are tracked somewhere.

Acceptance Criteria

Tasks to complete

  • Sphinx Design link cards (as seen on the home page) - focus ring is broken (squished, very narrow) due to the way the link is rendered
  • Sidebar TOC dropdown "chevron" button (does not receive focus and does not work with space or enter key)
  • Focus ring for tabs not yet implemented
  • Toggle (hamburger) button for left/primary mobile sidebar overlay (does not receive focus and does not work with space key or enter key). Open question: does it need to work with keyboard?
  • Button focus rings need to be changed to match the color of the button
  • Toggle (hamburger) button for right/secondary mobile sidebar overlay (receives focus, has focus ring, but does not respond to space or enter key). Open question: does it need to work with keyboard?
  • Some weird artifact for API "source" links, where a second blank focus ring appears at the end of the API method name:
    screenshot showing the two focus rings
  • There are too many copy buttons in notebook outputs
  • ipyleaflet receives focus but does not show focus ring
@gabalafou gabalafou added the type: task 📌 A concrete, well-scoped item label Nov 15, 2023
@gabalafou gabalafou self-assigned this Nov 15, 2023
@gabalafou
Copy link
Contributor Author

gabalafou commented Apr 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task 📌 A concrete, well-scoped item
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant