Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyData Sphinx - Review the design system for focus state - buttons, dropdowns #33

Closed
4 tasks done
Tracked by #27
trallard opened this issue Jun 22, 2023 · 3 comments
Closed
4 tasks done
Tracked by #27

PyData Sphinx - Review the design system for focus state - buttons, dropdowns #33

trallard opened this issue Jun 22, 2023 · 3 comments
Assignees
@smeragoel
Labels
area: accessibility ♿ area: design 🎨 area: PyData-Sphinx mission: access-centred ♿ Access-centred practices work stream mission: web themes 💻 Improvements to documentation themes team: quansight-labs type: task 📌 A concrete, well-scoped item
Milestone
12 months

Comments

@trallard
Copy link
Member

trallard commented Jun 22, 2023 •
edited
Loading

Acceptance Criteria

Tasks
Beta Give feedback
  1. Buttons meet criteria #36
    area: accessibility ♿ area: design 🎨
    gabalafou
  2. Dropdowns meet the criteria #35
    5 of 5
    area: accessibility ♿ area: design 🎨
    gabalafou

Details (criteria)

  1. Text contrast: should be met now after updating the colours WCAG SC 1.4.3 - text contrast AA](https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum)
    • 4.5:1 ratio for text and background (text < 18pt or bold text < 14pt)
    • 3:1 ratio for text and background (text >= 18pt or bold text =< 14pt)
  2. Focus visible criteria - buttons, links, and navigation components meet at least WCAG 2.1 (designs account for changes in WCAG 2.2
  3. WCAG SC 1.4.11 - non-text contrast AA need a minimum 3:1 contrast ratio with adjacent colours
    • links should meet this already
    • need to double check for focus visible
  4. WCAG SC 1.4.1 - use of colour
    • Color is not used as the only visual means of conveying information, indicating an action, prompting a response, or distinguishing an optical element
  5. WCAG SC 1.4.13

Resources
@trallard trallard mentioned this issue Jun 22, 2023
Closed
@trallard trallard added this to the 12 months milestone Jun 22, 2023
@trallard trallard changed the title Review the design system for focus state - buttons, dropdowns PyData Sphinx - Review the design system for focus state - buttons, dropdowns Jul 4, 2023
@trallard
Copy link
Member Author

trallard commented Aug 1, 2023

Now that focus states are in the proposal stage - I propose we move onto buttons and/or tab components WDYT @smeragoel?

@smeragoel
Copy link

Sounds good, I'll get started on this

@trallard
Copy link
Member Author

trallard commented Aug 3, 2023

Relevant: pydata/pydata-sphinx-theme#1387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smeragoel smeragoel

Labels
area: accessibility ♿ area: design 🎨 area: PyData-Sphinx mission: access-centred ♿ Access-centred practices work stream mission: web themes 💻 Improvements to documentation themes team: quansight-labs type: task 📌 A concrete, well-scoped item
Projects
czi-scientific-python 🐍
Archived in project
Milestone
12 months
Development

No branches or pull requests
2 participants
@trallard @smeragoel