Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the design system for focus state - links #32

Closed
1 of 2 tasks
Tracked by #27
trallard opened this issue Jun 22, 2023 · 5 comments
Closed
1 of 2 tasks
Tracked by #27

Review the design system for focus state - links #32

trallard opened this issue Jun 22, 2023 · 5 comments
Assignees
Labels
area: accessibility ♿ area: design 🎨 mission: access-centred ♿ Access-centred practices work stream mission: web themes 💻 Improvements to documentation themes team: quansight-labs type: task 📌 A concrete, well-scoped item
Milestone

Comments

@trallard
Copy link
Member

trallard commented Jun 22, 2023

Acceptance Criteria

  • Focus visible criteria - buttons, links, and navigation components meet at least WCAG 2.1 (designs account for changes in WCAG 2.2
  • WCAG SC 1.4.11 - non-text contrast AA need a minimum 3:1 contrast ratio with adjacent colours
    • focus styles - links
    • focus styles - navbar items
  • WCAG SC 1.4.1 - use of colour
    • Color is not used as the only visual means of conveying information, indicating an action, prompting a response, or distinguishing a visual element
@trallard trallard changed the title Review the design system for focus and interactions Review the design system for focus and interactions - links Jun 22, 2023
@trallard trallard changed the title Review the design system for focus and interactions - links Review the design system for focus state - links Jun 22, 2023
@trallard trallard added type: task 📌 A concrete, well-scoped item mission: web themes 💻 Improvements to documentation themes mission: access-centred ♿ Access-centred practices work stream area: accessibility ♿ team: quansight-labs area: design 🎨 labels Jun 22, 2023
@trallard trallard added this to the 12 months milestone Jun 22, 2023
@smeragoel
Copy link

So I have been wrangling my brain, trying to come up with a nice design for focus state for links.

I don't have anything concrete now, but I just wanted to put an update here that this is in progress. Everything I'm coming up with seems to be a "bad" solution, but what I think I'll do is just get out all the bad designs and hopefully something will click and I'll have a concrete direction to move in. I might also just post some of those bad designs to get reviews on them if I'm hardstuck.

I'll be back here (super) soon 😅

@smeragoel
Copy link

Here are my proposals for focus state for links:

image

There are 4 options, which are permutations of 2 distinct styles (box and underline) and 2 colour optons (monochromatic teal vs teal + purple)

Here is a demo of these options in light and dark mode:
image
image

Here's my opinion on these options:

  1. For styles, I prefer box over underline. Because links have an underline in general, I think adding just a thicker underline in focus states could be missed, and adding a full box would be a more visible change. So (1,3) > (2,4)
  2. For colours, I think that the monochromatic colour scheme is better. I feel some visual vibrations with the purple in dark mode, and I only made these options to show how that would look, and I feel the monochrome version is more visually stable. So 1 > 3 and 2 > 4.

Overall, I would rank the options like this: 1 > 2 > 3 > 4

I think we can shortlist these to 2 or 3 options and then present them on the main repo

@trallard
Copy link
Member Author

I think we can go ahead and propose 1,2,3

@trallard
Copy link
Member Author

trallard commented Aug 1, 2023

Now that I have more time to sit down and write things, @smeragoel, I think you can open the proposal on the PyData Sphinx repo.

Your last comment with the screenshots + rationale should be good for this - unless you want to add a TLD;R at the top.

@trallard
Copy link
Member Author

trallard commented Aug 8, 2023

Seems everyone is in the agreement of using the monochrome version so will mark this as resolved 🎉

@trallard trallard closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility ♿ area: design 🎨 mission: access-centred ♿ Access-centred practices work stream mission: web themes 💻 Improvements to documentation themes team: quansight-labs type: task 📌 A concrete, well-scoped item
Projects
Archived in project
Development

No branches or pull requests

2 participants