Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saturation values calculate issue #1

Open
XianchaoZhang opened this issue Jun 2, 2022 · 1 comment
Open

Saturation values calculate issue #1

XianchaoZhang opened this issue Jun 2, 2022 · 1 comment

Comments

@XianchaoZhang
Copy link

There is one minor logic problem when calculating saturation value. It would always be true whatever the blc enable or disable in module_enable_status dict, this can be fixed by following change:

         # Saturation values should be carefully calculated if BLC module is activated
-        if 'blc' in self.cfg.module_enable_status:
+        if self.cfg.module_enable_status['blc']:
@QiuJueqin
Copy link
Owner

@XianchaoZhang That is an intentional design, not a bug. Saturation value should be a physics-based value, no matter whether blc module is enabled.

if 'blc' in self.cfg.module_enable_status

This statement is to check if the sensor adds a black level to the digital output. For those sensors do, this value should be subtracted before calculating saturation value, even blc module is not enabled. If key 'blc' not in 'module_enable_status', it means this sensor doesnt add a black level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants