From be77aad7630b082cb373588faa5e5f25cc12a25e Mon Sep 17 00:00:00 2001 From: ElePT Date: Wed, 14 Dec 2022 10:43:36 +0100 Subject: [PATCH 1/4] Fix bug metadata Co-authored-by: Julian Schuhmacher --- qiskit/primitives/estimator.py | 2 +- qiskit/primitives/sampler.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qiskit/primitives/estimator.py b/qiskit/primitives/estimator.py index 6f0d96f14100..5961781dbd11 100644 --- a/qiskit/primitives/estimator.py +++ b/qiskit/primitives/estimator.py @@ -109,7 +109,7 @@ def _call( rng = np.random.default_rng(seed) # Initialize metadata - metadata: list[dict[str, Any]] = [{}] * len(circuits) + metadata: list[dict[str, Any]] = [{} for _ in range(len(circuits))] bound_circuits = [] for i, value in zip(circuits, parameter_values): diff --git a/qiskit/primitives/sampler.py b/qiskit/primitives/sampler.py index 5a833572f19c..f3bea91926f5 100644 --- a/qiskit/primitives/sampler.py +++ b/qiskit/primitives/sampler.py @@ -101,7 +101,7 @@ def _call( rng = np.random.default_rng(seed) # Initialize metadata - metadata: list[dict[str, Any]] = [{}] * len(circuits) + metadata: list[dict[str, Any]] = [{} for _ in range(len(circuits))] bound_circuits = [] qargs_list = [] From d36711b474c7acd44f6825da67aba7ca15da2b35 Mon Sep 17 00:00:00 2001 From: ElePT Date: Wed, 14 Dec 2022 11:21:25 +0100 Subject: [PATCH 2/4] Add reno --- .../notes/fix-primitives-metadata-1e79604126e26b53.yaml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml diff --git a/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml b/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml new file mode 100644 index 000000000000..2b04ae5e9bbd --- /dev/null +++ b/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fixed a bug in the primitives' medatada where the list made copies by reference and + all elements were updated with the same value at every iteration. From ee36d4ec2941403cbf6642cfb1eab540c11d7d8b Mon Sep 17 00:00:00 2001 From: ElePT <57907331+ElePT@users.noreply.github.com> Date: Mon, 19 Dec 2022 12:48:47 +0100 Subject: [PATCH 3/4] Re-trigger CI --- .../notes/fix-primitives-metadata-1e79604126e26b53.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml b/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml index 2b04ae5e9bbd..a0ba2e312367 100644 --- a/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml +++ b/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml @@ -1,5 +1,5 @@ --- fixes: - | - Fixed a bug in the primitives' medatada where the list made copies by reference and + Fixed a bug in the primitives' medatada, where the list made copies by reference and all elements were updated with the same value at every iteration. From 6fa04bde293cbccc11c7516fe48dfd1fb10a6801 Mon Sep 17 00:00:00 2001 From: ElePT <57907331+ElePT@users.noreply.github.com> Date: Mon, 19 Dec 2022 15:55:24 +0100 Subject: [PATCH 4/4] Fix typo Co-authored-by: Ikko Hamamura --- .../notes/fix-primitives-metadata-1e79604126e26b53.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml b/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml index a0ba2e312367..bdf55e99debc 100644 --- a/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml +++ b/releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml @@ -1,5 +1,5 @@ --- fixes: - | - Fixed a bug in the primitives' medatada, where the list made copies by reference and + Fixed a bug in the primitives' metadata, where the list made copies by reference and all elements were updated with the same value at every iteration.