Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalReadoutMitigator.quasi_probabilities incorrectly handles the shots argument #9154

Closed
eendebakpt opened this issue Nov 17, 2022 · 0 comments · Fixed by #9155
Closed

LocalReadoutMitigator.quasi_probabilities incorrectly handles the shots argument #9154

eendebakpt opened this issue Nov 17, 2022 · 0 comments · Fixed by #9155
Labels
bug Something isn't working

Comments

@eendebakpt
Copy link
Contributor

eendebakpt commented Nov 17, 2022 •
edited
Loading

Environment

  • Qiskit Terra version: 0.22.2
  • Python version: 3.10
  • Operating system: Windows

What is happening?

  1. The LocalReadoutMitigator.quasi_probabilities method has an argument shots which is not used in the method (it is overwritten by the output of counts_probability_vector)
  2. The method returns an object of type QuasiDistribution. It would be good to set the number of shots on that method
  3. The documentation on the return type of counts_probability_vector is incomplete

How can we reproduce the issue?

What should happen?

The number of shots argument should be used, or removed, or documented to be unused.

Any suggestions?

No response
@eendebakpt eendebakpt added the bug Something isn't working label Nov 17, 2022
@peendebak peendebak mentioned this issue Nov 17, 2022
Merged
@mergify mergify bot closed this as completed in #9155 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shots argument of local_readout_mitigator peendebak/qiskit-terra
1 participant
@eendebakpt