Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split QFI into QFI and QGT #9052

Closed
Cryoris opened this issue Nov 2, 2022 · 2 comments · Fixed by #9085
Closed

Split QFI into QFI and QGT #9052

Cryoris opened this issue Nov 2, 2022 · 2 comments · Fixed by #9085
Labels
mod: algorithms Related to the Algorithms module type: feature request New feature or request
Milestone

Comments

@Cryoris
Copy link
Contributor

Cryoris commented Nov 2, 2022

What should we add?

The current QFI implementation doesn't properly reflect that the QFI is purely real, as the code allows to take also imaginary parts of it. Instead we should have a class for the quantum geometric tensor (QGT) that allows to take real, imaginary and real+imaginary parts and build the QFI on it, using QFI = 4 * Re(QGT). In summary:

class QGT:
    def __init__(self, derivative_type=DerivativeType.COMPLEX):
        ...

class LinCombQGT:
    ...

class LinCombQFI:
    def __init__(self):
        self.qgt = LinCombQGT(derivative_type=DerivativeType.REAL)
        
    def run(self, ...):
        return 4 * self.qgt.run(...) 
@Cryoris Cryoris added the type: feature request New feature or request label Nov 2, 2022
@Cryoris Cryoris added this to the 0.23.0 milestone Nov 2, 2022
@Cryoris
Copy link
Contributor Author

Cryoris commented Nov 2, 2022

@a-matsuo

@Cryoris Cryoris added the mod: algorithms Related to the Algorithms module label Nov 2, 2022
@mtreinish mtreinish modified the milestones: 0.23.0, 0.24.0 Jan 9, 2023
@Cryoris Cryoris modified the milestones: 0.24.0, 0.23.0 Jan 12, 2023
@Cryoris
Copy link
Contributor Author

Cryoris commented Jan 12, 2023

As discussed, we're adding this to the 0.23 milestone again 🙂

@mergify mergify bot closed this as completed in #9085 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: algorithms Related to the Algorithms module type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants