Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some internal polishing is needed in the QASM3 exporter #7136

Closed
3 tasks
1ucian0 opened this issue Oct 14, 2021 · 3 comments · Fixed by #12776
Closed
3 tasks

Some internal polishing is needed in the QASM3 exporter #7136

1ucian0 opened this issue Oct 14, 2021 · 3 comments · Fixed by #12776
Labels
mod: qasm3 Related to OpenQASM 3 import or export type: enhancement It's working, but needs polishing

Comments

@1ucian0
Copy link
Member

1ucian0 commented Oct 14, 2021

This is a #6565 follow up

This particular issue tracks:

  • The GlobalNamespace._data is horrendous and needs to be split. More here.
  • Merge GlobalNamespace and Exporter.
  • Better Namespace validation and renaming, see here and here.
@1ucian0 1ucian0 added type: enhancement It's working, but needs polishing mod: qasm2 Relating to OpenQASM 2 import or export labels Oct 14, 2021
@1ucian0 1ucian0 mentioned this issue Oct 14, 2021
3 tasks
@Ryand1234
Copy link

Hi @1ucian0, Can I work on this?

@jakelishman
Copy link
Member

Hi @Ryand1234! This might not be the best choice for an external contributor, sorry - this issue is mostly a tracker for the core team, because we'll be making fairly heavy changes to the QASM 3 processing in Terra over the next few release cycles, and these changes will be part of it. The changes needed for this issue are very major to a core deliverable in Terra 0.20 which will have quite a lot of activity, so it'll be a bit easier for us to manage if we keep this internal.

If you're looking for good issues, we have the "good first issue" label for issues that are good for first-time contributors, and the "help wanted" label for those with a bit more experience. There's also "short project", and these may require a fair amount of physics knowledge to handle.

@jakelishman jakelishman added mod: qasm3 Related to OpenQASM 3 import or export and removed mod: qasm2 Relating to OpenQASM 2 import or export labels Jun 15, 2023
@jakelishman
Copy link
Member

#12776 addresses all the problems tracked by this issue. There's still obviously polishing that could be done, but I've marked this issue as closed by #12776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: qasm3 Related to OpenQASM 3 import or export type: enhancement It's working, but needs polishing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants