Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Inconsistencies in rendering docs vs. Jupyter notebooks (Qiskit Optimization) #1042

Closed
Travis-S-IBM opened this issue Sep 21, 2020 · 7 comments
Labels
documentation Something is not clear or error in description

Comments

@Travis-S-IBM
Copy link

This issue points out some places where information (mostly text) is rendered inconsistently between the docs on qiskit.org/documentation and the corresponding Jupyter notebooks which generate the pages.

1 Quadratic Program

  • Above cell 13, the list of substitutions gets inlined.

2 Converters for Quadratic Programs

  • The list of converters in the opening paragraphs gets inlined.

3 Minimum Eigen Optimizer

  • The list of MinimumEigenSolvers in the opening paragraphs gets inlined.
  • The hyperlinks for references 1 and 2 are not rendered correctly.

4 Grover Optimizer

  • The hyperlink for reference 1 is not rendered correctly.

5 ADMM Optimizer

  • The hyperlinks for references 1 and 2 are not rendered correctly.
  • The list of solvers just under cell 1 gets inlined.

6 Max-Cut and Traveling Salesman Problem

  • The steps listed in the 2nd paragraph of section Approximate Universal Quantum Computing for Optimization Problems are inlined.
  • The references above Cell 2 are inlined.

7 Vehicle routing

  • The list just above Cell 9 gets inlined.
@Travis-S-IBM Travis-S-IBM added the documentation Something is not clear or error in description label Sep 21, 2020
@Travis-S-IBM
Copy link
Author

@nonhermitian Who would be the person to work with to figure out why these inconsistencies happen?

@nonhermitian
Copy link
Contributor

Limitations number four in the readme might help.

@Travis-S-IBM
Copy link
Author

@nonhermitian How so? There's no math in these lists....

Is there a doc somewhere that outlines how the rendering as RST files works?

@nonhermitian
Copy link
Contributor

Ok, I guess I misunderstood the issues. Here is a link to the conversion program docs:

https://nbsphinx.readthedocs.io/en/0.7.1/

In short, Sphinx parsing is much more strict than that allowed in Jupyter notebooks. This is why you are seeing what you do.

@mtreinish
Copy link
Member

It's worth pointing out the actual rst generation is done using pandoc (at least until spatialaudio/nbsphinx#36 is implemented). Basically nbsphinx runs nbconvert on the notebook to generate a markdown file then runs pandoc on that markdown output to generate restructured text which is what gets passed to sphinx for building the html version. The pandoc conversion is where I expect this is going wrong, there are a lot of edge cases there and pandoc doesn't always know what a renderer is looking for.

@nonhermitian
Copy link
Contributor

Closing as (kind of) solved. Can reopen if otherwise.

@shil-m
Copy link
Contributor

shil-m commented Jun 14, 2021

Ok, I guess I misunderstood the issues. Here is a link to the conversion program docs:

https://nbsphinx.readthedocs.io/en/0.7.1/

In short, Sphinx parsing is much more strict than that allowed in Jupyter notebooks. This is why you are seeing what you do.

Has this been fixed? Because the documentation is still inconsistent for 6 Max-Cut and Traveling Salesman Problem

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Something is not clear or error in description
Projects
None yet
Development

No branches or pull requests

4 participants