Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstring missing for Sampler.close() #1803

Closed
hhorii opened this issue May 10, 2023 · 0 comments · Fixed by #1804
Closed

docstring missing for Sampler.close() #1803

hhorii opened this issue May 10, 2023 · 0 comments · Fixed by #1804
Labels
bug Something isn't working

Comments

@hhorii
Copy link
Collaborator

hhorii commented May 10, 2023

Informations

  • Qiskit Aer version:
  • Python version:
  • Operating system:

What is the current behavior?

Since Qiskit/qiskit@75673c7 of Terra, close() is removed from Sampler but AerSampler has close() with assuming that docstring exists in its base class. This mismatch causes Lint error: qiskit_aer/primitives/sampler.py:161:4: C0116: Missing function or method docstring (missing-function-docstring).

Steps to reproduce the problem

Just run lint.

What is the expected behavior?

Pass Lint.

Suggested solutions

Add docstring to close() or change Sampler implementation in Aer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant