Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature propose: Make whole search result area clickable #285

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

laysent
Copy link
Contributor

@laysent laysent commented Oct 17, 2017

Hi, I would like to propose a change to search plugin. Currently, only the title of search result is clickable. It might sound a bit weird for users as the search content is plain text and cannot redirect them.

This PR will make the complete area clickable by wrapping the whole area with a tag.

One thing to notice is that the search keyword will be rendered using theme color, the same color when mouse hovered. To distinguish them, I made the keyword also bold.

How it looks when displaying search result:

image

How it looks when mouse hovered:

image

Should work fine with all default themes. But perhaps not a very well-designed. Let me know if you have any feedback.

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@QingWei-Li QingWei-Li merged commit 1b91227 into docsifyjs:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants