Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes implemented in headers #951

Open
1 task
PDoakORNL opened this issue Aug 1, 2018 · 2 comments
Open
1 task

Classes implemented in headers #951

PDoakORNL opened this issue Aug 1, 2018 · 2 comments
Assignees

Comments

@PDoakORNL
Copy link
Contributor

Sometimes its acceptable for templates to implement even very long methods in headers, the rest of the time it just makes the build slow and blurs interface and implementation.

This is a list of classes that should find themselves mostly in a .cpp soon. Unless explanations or objections are made.

  • SPOSetScanner.h
@ye-luo
Copy link
Contributor

ye-luo commented Aug 1, 2018

SPOSetScanner is not really an important one. It is included in two builder cpp files.

@PDoakORNL
Copy link
Contributor Author

My intention is for this issue to collect a list. I just was looking at that file when I wrote it. Didn't mean to single out SPOSetScanner.h as a serious one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants