Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of MultiDiracDeterminantWithBackflow #826

Closed
jtkrogel opened this issue May 2, 2018 · 7 comments
Closed

Status of MultiDiracDeterminantWithBackflow #826

jtkrogel opened this issue May 2, 2018 · 7 comments
Assignees
Labels

Comments

@jtkrogel
Copy link
Contributor

jtkrogel commented May 2, 2018

MultiDiracDeterminantWithBackflow.cpp was identified as a dangling (unbuilt) file during automated searches for dead code. What is the status of this code/should it be kept? Is there any functionality here that is not covered in MultiSlaterDeterminantWithBackflow?

@ye-luo
Copy link
Contributor

ye-luo commented May 2, 2018

It seems out-of-date and all the routines have a linked copy in MultiDiracDeterminantBase.cpp and MultiDiracDeterminantBase.2.cpp

@prckent
Copy link
Contributor

prckent commented May 2, 2018

Note: We are recently using the backflow functionality, but with single determinants. Use of multideterminants with backflow is a proven improvement. Does MultiSlaterDeterminantWithBackflow work?

@jtkrogel
Copy link
Contributor Author

jtkrogel commented May 3, 2018

Will remove.

@jtkrogel jtkrogel closed this as completed May 4, 2018
@mmorale3
Copy link
Contributor

mmorale3 commented May 4, 2018 via email

@ye-luo
Copy link
Contributor

ye-luo commented May 4, 2018

As far as I know, now we have the following classes.
MultiSlaterDeterminant: dummy implementation directly creating N determinants
MultiSlaterDeterminantWithBackflow: the previous one + backflow
MultiSlaterDeterminantFast: the table method.
MultiDiracDeterminantBase: operates at single det level to provide calculations for the above three.

MultiSlaterDeterminantFast is the main one used to do MSD. Probably MultiSlaterDeterminant can operate but slower. MultiSlaterDeterminantWithBackflow carries all the character of MultiSlaterDeterminant.

To move forward, I think we need to add Backflow on top of the fast algorithm and remove the dummy ones. On the other hand, backflow can be largely improved by itself, I saw similar problems like the AoS Jastrows in the backflow. So I think first, we improve the backflow on single det and then bring it to the fast multidet class.

@prckent
Copy link
Contributor

prckent commented May 4, 2018

It might be useful to have a slow (traditional) multiple determinant implementation available too.

This is well defined topic that will need investigating as we learn about the effectiveness (cost, accuracy) of different ways to improve the nodal surfaces.

@ye-luo
Copy link
Contributor

ye-luo commented May 4, 2018

Tests are requested by #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants