-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Introduce QMC_GPU cmake option #5267
Conversation
Test this please |
Concentrate user facing CMake options to QMC_GPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ye.
While updating these config options, can you document USE_OBJECT_TARGET ? It is only mentioned in the CMakeLists.txt
Once this is in and working we should review and update the recipes in config/ to use QMC_GPU.
@prckent |
Worth mentioning in https://github.com/QMCPACK/qmcpack/blob/develop/CHANGELOG.md |
Test this please |
Test this please |
Proposed changes
Replace
ENABLE_CUDA
,ENABLE_ROCM
,QMC_CUDA2HIP
,ENABLE_SYCL
andENABLE_OFFLOAD
CMake options with a single user facing optionQMC_GPU
proposed in #5250What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist