Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy init cu/rocsolver #5265

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Lazy init cu/rocsolver #5265

merged 2 commits into from
Jan 2, 2025

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 2, 2025

Proposed changes

Should address #5260.
Works fine on my 3060Ti with 8GB VRAM.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

@ye-luo ye-luo force-pushed the lazy-init-cusolver branch from 466fa3a to 3f6980e Compare January 2, 2025 19:58
@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 2, 2025

Test this please

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try; lets merge and watch.

Thanks also for the cleanup.

@prckent prckent enabled auto-merge January 2, 2025 20:43
@prckent prckent merged commit eab6555 into QMCPACK:develop Jan 2, 2025
37 of 39 checks passed
prckent added a commit that referenced this pull request Jan 2, 2025
@ye-luo ye-luo deleted the lazy-init-cusolver branch January 2, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants