Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set full precision batched recomputation default #5249

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Dec 3, 2024

Proposed changes

Missed in #4109 . Set batched full precision recomputation frequency consistent with documentation. Credit to Ye for noticing.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Sulfur, GCC14 nightly config, via grep.

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
    -No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor Author

prckent commented Dec 3, 2024

Test this please

@ye-luo ye-luo enabled auto-merge December 3, 2024 16:45
@prckent prckent added the bug label Dec 3, 2024
@ye-luo ye-luo merged commit 4eff0d0 into QMCPACK:develop Dec 3, 2024
38 of 39 checks passed
@prckent prckent deleted the batch_recompute_default branch December 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants