-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more explanation about energy density #2163
Comments
You should be able to use the energy density estimator without any ions, though some plumbing would need to be added to support the external potential. Currently, the estimator is broken (see #982) but I am currently working to restore it (#2156 was a step toward this). If you will provide a working set of input files for your use case, I will try give it a look as I switch the lights back on. |
This is the input file I am currently working with. I am using a fork of qmcpack, where I can read in a potential on a grid. I am also reading in SPOs from qbox.
|
Is it possible/advisable to merge your fork into mainline via a PR? How large is |
I have verified that this feature works in the case of a SHO in periodic boundary conditions but I have not done extensive testing of this feature, and the wfs.h5 file is 43 MB. |
I only ask because it would make it easier to ensure that the restored estimator works in your case. How would you prefer to proceed? |
I could create a PR for my fork. That way the plumbing can be done to include an external potential in the energy density estimator. |
Sounds good. I will look for your PR. |
Hi @jtkrogel, I'm not sure if you have seen, but I have a pull request that is close to being finished :-) |
Great. Please upload a working set of files here once it is in so I can ensure your case works with the eventual energy density fix. |
So the PR has gone through, but there is another issue now that I have opened with reading in QBox info when there are no ions in the system. To work around this I modified line 133 of
I have opened another issue for it, and there may be a better solution. In saying that, everything seems OK to me from what I have seen, and this is an orthogonal issue. Here is a link to the files: https://drive.google.com/file/d/16PJvYmL3bShneQubkgmFWy7HlReM-B9L/view?usp=sharing In the Hamiltonian section you just need to add:
|
I have added another PR to fix the no ion issue. Any updates on your end? |
Sorry, no updates yet. I've been progressing slowly on this due to work on #2105. |
No problem, let me know when you get some time to check it out. If there is anything I could do to get started you could let me know! A PR went through to allow for an empty ions particle set, so now I have that working natively with an external potential. Basically, in the input file you must define:
followed by
and everything should work. |
Any updates yet? Is there a reason why the energy density wouldn't work with a new potential? |
It is mainly a data routing issue. Right now the energy density does not work with any potential, see #982. It will take some time to fix. Due to a mix of work items, I may not be able to get to this before midsummer. |
do you know of anyone else who can look into it? |
@markdewing could you possibly help out here? |
The energy density now works. |
From reading the manual, it seems like one can compute the energy density of a system using qmcpack. I have a system with 8 electrons in an external potential, therefore no ions.
Kevin
The text was updated successfully, but these errors were encountered: