Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More convenient calls of coordinate maps #74

Open
szabo137 opened this issue Oct 23, 2024 · 0 comments
Open

More convenient calls of coordinate maps #74

szabo137 opened this issue Oct 23, 2024 · 0 comments
Labels
06 - Feature-request Missing a feature or functionality good first issue Good for newcomers

Comments

@szabo137
Copy link
Member

Currently, the calls for coordinate maps depend on the psl, which was passed in the construction:

# Create a coordinate map for in-phase space
in_coord_map = CoordinateMap(proc, model, in_psl)

# call on in-coordinates to build the momenta
in_coord_map(in_coords)

# Create a coordinate map for out-phase space
coord_map = CoordinateMap(proc, model, out_psl)

# Call on in- and out-coordinates to build the momenta
coord_map(in_coords, out_coords)

However, it would be very convenient to return the in-momenta also on call of the coord_map:

# Create a coordinate map for out-phase space (which contains the in_psl by design)
coord_map = CoordinateMap(proc, model, out_psl)

# Call on in- to build the in momenta
coord_map(in_coords)
@szabo137 szabo137 added 06 - Feature-request Missing a feature or functionality good first issue Good for newcomers labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
06 - Feature-request Missing a feature or functionality good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant