-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No mention in docs about using default=colander.drop
#237
Comments
Okay, it seems that this is mentioned in the CHANGES.rst but no one has updated the documentation. |
colander.drop should be used as value for missing, not default
|
@tisdall - Oh I missed that one, I didn't know colander.drop could be used that way. Thanks for pointing it. |
@tonthon, and do you know why you didn't know? Because it's not in the docs! |
Is there a PR that closes this issue? I can merge a PR for the docs only, but not code as I don't have the necessary familiarity. |
@stevepiercy #238 is sort-of docs only... ^_^ But, no, I haven't made anything to update the docs regarding this. I'm not working with colander right now so I likely won't be submitting a PR either so it's open for someone to contribute. |
A PR improving the docs for this feature is likely to be accepted. Any movement on this? |
Forgot to put a reference to this issue in the pull request #248 |
fixed in #248 |
You can apparently use a
colander.drop
as a value fordefault
, but there's no mention in the documents.Example:
Now, I find this feature very useful for what I'm working on. However, before I work on updating the docs to mention how this works, does anyone have any reasons for this to be labelled a bug?
The text was updated successfully, but these errors were encountered: