Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanity URL cannot be edited anymore #2477

Closed
3 tasks done
Lumabots opened this issue Jun 19, 2024 · 5 comments · Fixed by #2491
Closed
3 tasks done

Vanity URL cannot be edited anymore #2477

Lumabots opened this issue Jun 19, 2024 · 5 comments · Fixed by #2491
Assignees
Labels
API Reflection Discords API wasn't correctly reflected in the lib priority: medium Medium Priority

Comments

@Lumabots
Copy link

Summary

Guild edit has attribute vanity_role while he cant edit that

Reproduction Steps

vanity_code: :class:`str`

Minimal Reproducible Code

No response

Expected Results

N/A

Actual Results

N/A

Intents

N/A

System Information

N/A

Checklist

  • I have searched the open issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have removed my token from display, if visible.

Additional Context

No response

@Lumabots Lumabots added the unconfirmed bug A bug report that needs triaging label Jun 19, 2024
@Dorukyum Dorukyum added bug Something isn't working priority: medium Medium Priority and removed unconfirmed bug A bug report that needs triaging labels Jul 3, 2024
@Dorukyum Dorukyum self-assigned this Jul 3, 2024
@Dorukyum Dorukyum added unconfirmed bug A bug report that needs triaging and removed bug Something isn't working labels Jul 3, 2024
@Dorukyum
Copy link
Member

Dorukyum commented Jul 3, 2024

This is handled through a different endpoint.

pycord/discord/guild.py

Lines 1762 to 1763 in 9ab4bd6

if vanity_code is not MISSING:
await http.change_vanity_code(self.id, vanity_code, reason=reason)

pycord/discord/http.py

Lines 1631 to 1639 in ec3cf16

def change_vanity_code(
self, guild_id: Snowflake, code: str, *, reason: str | None = None
) -> Response[None]:
payload: dict[str, Any] = {"code": code}
return self.request(
Route("PATCH", "/guilds/{guild_id}/vanity-url", guild_id=guild_id),
json=payload,
reason=reason,
)

@Dorukyum Dorukyum closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
@Dorukyum Dorukyum removed the priority: medium Medium Priority label Jul 3, 2024
@NeloBlivion
Copy link
Member

NeloBlivion commented Jul 3, 2024

I think they meant it shouldn't be available because bots cannot use the endpoint (not documented, and searching on DDevs shows this is intentional)
I recall reading up on this recently but it completely slipped my mind

@Lulalaby
Copy link
Member

Lulalaby commented Jul 4, 2024

that is correct. bots can't change it anymore do to it being a big attack vector afaik for stealing and gatekeeping vanities.

@Lulalaby Lulalaby reopened this Jul 4, 2024
@Lulalaby Lulalaby added priority: medium Medium Priority API Reflection Discords API wasn't correctly reflected in the lib and removed unconfirmed bug A bug report that needs triaging labels Jul 4, 2024
@Dorukyum
Copy link
Member

Dorukyum commented Jul 4, 2024

Then we can remove the other method.

@Dorukyum Dorukyum changed the title Doc Guild Edit not up to date Vanity URL cannot be edited anymore Jul 4, 2024
@Lulalaby
Copy link
Member

Lulalaby commented Jul 4, 2024

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib priority: medium Medium Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants