Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: adopt the SciPy Code of Conduct #521

Merged
merged 5 commits into from
Oct 15, 2019

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Oct 4, 2019

As discussed in #267, this PR adopts the Code of Conduct from SciPy.

I did not make any changes to the terms aside from renaming the project and committee members and removing mention of NumFOCUS as we are not a NumFOCUS-sponsored project. My changes to the CoC text are isolated to commit 8da2b32.

I think the main drawback here as compared to SciPy itself is the smaller committee size and the lack of a good alternative reporting mechanism without NumFOCUS support. That may be the best we can do for now, but let me know if you have any other ideas.

I suppose one alternative would be to also solicit an additional committee member from the broader scientific Python community.

@grlee77 grlee77 added this to the v1.1 milestone Oct 4, 2019
@grlee77 grlee77 requested a review from rgommers October 4, 2019 22:30
PyWavelets-conduct@googlegroups.com. Currently, the committee consists of:

- Gregory Lee
- Ralf Gommers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to invite a third person here, perhaps from scikit-image since they rely on pywavelets and likely someone on that team will be happy to help out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include the committee member's email addresses here? (or were those deliberately omitted to reduce spam?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be needed I think. And if someone really wants to find us, they can look at the commit log so it's not impossible. I'd leave it out here.

@rgommers
Copy link
Member

rgommers commented Oct 5, 2019

LGTM. Let's leave it open for some days, this is an important topic so let's make sure to give anyone interested in it the time to respond.

@PyWavelets/core-contributors any comments or approvals?

@grlee77
Copy link
Contributor Author

grlee77 commented Oct 8, 2019

@alexdesiqueira (a scikit-image core dev) has kindly volunteered to serve as a participant on our committee. I will update the text to reflect this soon.

@rgommers
Copy link
Member

rgommers commented Oct 9, 2019

Thanks for offering to help @alexdesiqueira!

Alexandre de Siqueira is a scikit-image maintainer
@rgommers
Copy link
Member

No more commments in the last week, so let's get this in. Thanks a lot for doing this @grlee77, and @alexdesiqueira for volunteering to be on the committee.

@rgommers rgommers merged commit 2cced50 into PyWavelets:master Oct 15, 2019
@grlee77 grlee77 deleted the code_of_conduct branch November 13, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants