Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: shape adjustment in waverec should not assume a transform along … #294

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 7, 2017

…axis 0

see detailed description of the issue in #293

The basic issue relates to forward followed by inverse DWT of odd-sized data results in an array that is rounded up to the next largest even size. The various multilevel DWT routines truncate the extra sample appropriately to deal with this. This fixes a bug where this was not done appropriately in waverec when axis != 0.

@grlee77 grlee77 added the bug label Mar 7, 2017
@grlee77 grlee77 added this to the v1.0 milestone Mar 7, 2017
The ValueError raised is the same as the one in idwt
@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #294 into master will decrease coverage by -0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   86.26%   86.22%   -0.04%     
==========================================
  Files          21       21              
  Lines        3086     3092       +6     
  Branches      532      535       +3     
==========================================
+ Hits         2662     2666       +4     
- Misses        371      373       +2     
  Partials       53       53
Impacted Files Coverage Δ
pywt/_multilevel.py 92.6% <75%> (-0.56%)
pywt/_wavelet_packets.py 78.12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ee638...66df1ca. Read the comment docs.

@grlee77 grlee77 mentioned this pull request Mar 8, 2017
@rgommers rgommers merged commit d90ae91 into PyWavelets:master Mar 9, 2017
@rgommers
Copy link
Member

rgommers commented Mar 9, 2017

LGTM, merged.

@grlee77 grlee77 deleted the waverec_axis_fix branch March 10, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants