[IPU] Add reset dataloader hooks to training type plugin 3/n #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2021 17:03
SeanNaren
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
SeanNaren
added
3rd party
Codecov Report
@@ Coverage Diff @@
## master #7861 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 202 202
Lines 13054 13073 +19
=======================================
- Hits 12088 11480 -608
- Misses 966 1593 +627 |
awaelchli
approved these changes
Jun 7, 2021
justusschock
approved these changes
Jun 7, 2021
carmocca
approved these changes
Jun 7, 2021
Borda
pushed a commit
that referenced
this pull request
Jun 8, 2021
* Add hooks * Add tests for hooks * Add changelog * Test changes, add typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds reset data-loader hooks to the training type plugin and accelerator.
The requirement here was that
process_dataloader(The currently exposed hook) happens too late in the flow, not updating the progress bar etc. This till now has been fine as the assumption is the size of the batches do not change, however this is not true with IPUs.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃