Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear predict_progress_bar in ProgressBar.__getstate__ #7608

Merged
merged 10 commits into from
May 20, 2021

Conversation

yifuwang
Copy link
Contributor

@yifuwang yifuwang commented May 19, 2021

What does this PR do?

Fixes #7567

tqdm is not pickle-able. ProgressBar.__getstate__() clears main_progress_bar, val_progress_bar, and test_progress_bar but somehow not predict_progress_bar. This PR addresses the issue.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the v1.3.x milestone May 19, 2021
@carmocca carmocca added the bug Something isn't working label May 19, 2021
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yifuwang

thanks for your fix.

Could you try to get in some tests for that?

Feel free to take them over from #7609 (which I closed in favour of your PR) :)

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #7608 (0e597f5) into master (20f6337) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7608    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         197     198     +1     
  Lines       12878   12932    +54     
=======================================
- Hits        11899   11370   -529     
- Misses        979    1562   +583     

@yifuwang yifuwang requested a review from SeanNaren as a code owner May 19, 2021 14:44
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test and updated the CHANGELOG

tests/callbacks/test_progress_bar.py Outdated Show resolved Hide resolved
@Borda Borda added ready PRs ready to be merged and removed ready PRs ready to be merged labels May 19, 2021
@carmocca carmocca enabled auto-merge (squash) May 20, 2021 01:12
@carmocca carmocca merged commit ed27190 into Lightning-AI:master May 20, 2021
awaelchli added a commit that referenced this pull request May 25, 2021
Co-authored-by: Yifu Wang <yifuwang@2012@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@Borda Borda mentioned this pull request May 25, 2021
Borda pushed a commit that referenced this pull request May 26, 2021
Co-authored-by: Yifu Wang <yifuwang@2012@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request May 26, 2021
Co-authored-by: Yifu Wang <yifuwang@2012@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model becames unpickable after calling trainer.predict(model, dataloader)
6 participants