Fix toggle optimizer #5775
Merged
Fix toggle optimizer #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5775 +/- ##
=======================================
- Coverage 94% 93% -0%
=======================================
Files 134 134
Lines 10053 9913 -140
=======================================
- Hits 9409 9255 -154
- Misses 644 658 +14 |
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
12 tasks
ananthsub
commented
Feb 4, 2021
s-rog
reviewed
Feb 4, 2021
pytorch_lightning/core/lightning.py
Outdated
Comment on lines
1187
to
1188
| if param in param_requires_grad_state: | ||
| param.requires_grad = param_requires_grad_state[param] |
There was a problem hiding this comment.
This forces all optimizers to have the same grad state for all params?
|
@ananthsub could you please add a test so we won't accidentally break it again... |
tchaton
reviewed
Feb 4, 2021
There was a problem hiding this comment.
Hey @ananthsub,
I apologise this part wasn't better tested and I introduced a critical bug.
I think there were still a bug in the code with the missing continue.
I have added a test with 3 optimizers.
Would you mind to check if everything works fine for you ?
Best,
T.C
|
Hello @ananthsub! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-04 20:27:46 UTC |
SeanNaren
reviewed
Feb 4, 2021
carmocca
approved these changes
Feb 4, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
|
thanks @tchaton for the test cases - confirming that this patch works for me |
tchaton
approved these changes
Feb 4, 2021
tchaton
added a commit
that referenced
this pull request
Feb 5, 2021
* Update lightning.py * update changelog * add a 3 optimizer test * resolve flake8 * remove extra code * typo * resolve typo * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: tchaton <thomas@grid.ai> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda
pushed a commit
that referenced
this pull request
Feb 5, 2021
* Update lightning.py * update changelog * add a 3 optimizer test * resolve flake8 * remove extra code * typo * resolve typo * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: tchaton <thomas@grid.ai> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda
pushed a commit
that referenced
this pull request
Feb 5, 2021
* Update lightning.py * update changelog * add a 3 optimizer test * resolve flake8 * remove extra code * typo * resolve typo * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: tchaton <thomas@grid.ai> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5292
This more closely follows the suggestions from the issue. Inside of
toggle_optimizers, first we scan over allrequires_gradvalues for all the parameters and store them on the lightning module., and setrequires_grad=False. Then we iterate over the values of the current optimizer's parameters and set them according to the dictionary created from the initial scan.The issue with the initial fix was multiple optimizers with shared parameters were handled incorrectly.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃