-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: 1/n legacy accelerators and plugins #5645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
January 25, 2021 11:07
16 tasks
Borda
force-pushed
the
refactor/legacy-accel-plug
branch
from
January 25, 2021 13:54
bf200bf
to
bc23966
Compare
justusschock
approved these changes
Jan 25, 2021
awaelchli
approved these changes
Jan 25, 2021
SeanNaren
approved these changes
Jan 25, 2021
Borda
force-pushed
the
refactor/legacy-accel-plug
branch
from
January 26, 2021 07:45
961849a
to
5d46913
Compare
Borda
force-pushed
the
refactor/legacy-accel-plug
branch
from
January 26, 2021 09:58
062f090
to
a101751
Compare
tchaton
changed the title
Refactor: legacy accelerators and plugins
Refactor: 1/n legacy accelerators and plugins
Jan 26, 2021
tchaton
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
reviewed
Jan 26, 2021
Borda
force-pushed
the
refactor/legacy-accel-plug
branch
from
January 26, 2021 12:42
6f0fb0a
to
cf8d5b2
Compare
carmocca
approved these changes
Jan 26, 2021
Borda
force-pushed
the
refactor/legacy-accel-plug
branch
from
January 26, 2021 14:44
cf8d5b2
to
545276b
Compare
Borda
force-pushed
the
refactor/legacy-accel-plug
branch
from
January 26, 2021 20:12
34cceb7
to
d140411
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5645 +/- ##
=================================================
- Coverage 93% 89% -3%
=================================================
Files 154 163 +9
Lines 11040 12070 +1030
=================================================
+ Hits 10216 10795 +579
- Misses 824 1275 +451 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
moving actual accelerators and plugins to its legacy sub-package to not interfere with the new structure
This is the initial step for #5616
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃