-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Adding PruningCallback #5618
Conversation
Hello @tchaton! Thanks for updating this PR.
Comment last updated at 2021-01-27 01:05:25 UTC |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5618 +/- ##
================================================
Coverage 89% 89%
================================================
Files 163 164 +1
Lines 12070 12218 +148
================================================
+ Hits 10795 10928 +133
- Misses 1275 1290 +15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a high-level review...
Additional comments:
- there is an empty file
pytorch_lightning/callbacks/pruning_utils/__init__.py
that probably can be deleted - insert link in the
Built-in Callbacks
section in thecallbacks.rst
doc file
Excited to use this :) |
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, less some nits. Will leave it to other to approve
What does this PR do?
This PR adds a pruning Callback.
Fixes # (issue) <- this links related issue to this PR
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃