-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set xxx_AVAILABLE as protected #5082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5082 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 134 134
Lines 9907 9906 -1
======================================
- Hits 9206 9205 -1
Misses 701 701 |
eb20abb
to
5b31802
Compare
Im not sure we really need this. I think we should just not export it through init and then we should be fine. |
even we do not export it, users can still use it and complain... I would rather keep protected these 3rd-party checks... |
This pull request is now in conflict... :( |
5b31802
to
65263b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
all the variable are just for internal usage so we shall not expose them to the user
Moreover, users shall not rely on their correctness...
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃