Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set xxx_AVAILABLE as protected #5082

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 11, 2020

What does this PR do?

all the variable are just for internal usage so we shall not expose them to the user
Moreover, users shall not rely on their correctness...

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added refactor design Includes a design discussion labels Dec 11, 2020
@Borda Borda added this to the 1.1.x milestone Dec 11, 2020
@Borda Borda marked this pull request as ready for review December 11, 2020 09:51
@Borda Borda changed the title sett xxx_AVAILABLE as protected set xxx_AVAILABLE as protected Dec 11, 2020
@Borda Borda requested a review from edenlightning as a code owner December 11, 2020 10:12
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #5082 (5f39dd0) into master (0327f6b) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5082   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9907    9906    -1     
======================================
- Hits         9206    9205    -1     
  Misses        701     701           

@Borda Borda force-pushed the refactor/procest-avail branch from eb20abb to 5b31802 Compare December 11, 2020 15:17
@justusschock
Copy link
Member

Im not sure we really need this. I think we should just not export it through init and then we should be fine.

@Borda
Copy link
Member Author

Borda commented Dec 11, 2020

Im not sure we really need this. I think we should just not export it through init and then we should be fine.

even we do not export it, users can still use it and complain... I would rather keep protected these 3rd-party checks...

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2020

This pull request is now in conflict... :(

@mergify mergify bot requested a review from a team December 12, 2020 14:55
@Borda Borda force-pushed the refactor/procest-avail branch from 5b31802 to 65263b3 Compare December 13, 2020 22:52
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda added the ready PRs ready to be merged label Dec 14, 2020
@Borda Borda changed the base branch from master to release/1.2-dev December 14, 2020 11:33
@rohitgr7 rohitgr7 merged commit 059eaec into release/1.2-dev Dec 14, 2020
@rohitgr7 rohitgr7 deleted the refactor/procest-avail branch December 14, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants