-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix torchtext data to gpu #4785
Merged
ananyahjha93
merged 4 commits into
Lightning-AI:master
from
jungwhank:bugfix/4782_torchtextgpu
Nov 24, 2020
Merged
Fix torchtext data to gpu #4785
ananyahjha93
merged 4 commits into
Lightning-AI:master
from
jungwhank:bugfix/4782_torchtextgpu
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungwhank
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
November 20, 2020 09:45
Borda
approved these changes
Nov 20, 2020
Borda
added
bug
Something isn't working
data handling
Generic data-related topic
labels
Nov 20, 2020
Note: #3529 |
tchaton
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch !
Codecov Report
@@ Coverage Diff @@
## master #4785 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 118 118
Lines 9030 9032 +2
======================================
+ Hits 8403 8404 +1
- Misses 627 628 +1 |
rohitgr7
approved these changes
Nov 23, 2020
s-rog
approved these changes
Nov 24, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 24, 2020
Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 471ca37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4782
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃