Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Getter/Setter support for struct/unit tuples #1593

Closed
ruffson opened this issue May 3, 2021 · 2 comments · Fixed by #1651
Closed

Request: Getter/Setter support for struct/unit tuples #1593

ruffson opened this issue May 3, 2021 · 2 comments · Fixed by #1651

Comments

@ruffson
Copy link

ruffson commented May 3, 2021

So after this PR implemented support for unit/tuple structs in pyclass it would be awesome if getter/setters could be supported as suggested here.

As far as I understand, the support for names with getters/setters is already merged here.
@davidhewitt
Copy link
Member

Indeed it's on the plan👍. I plan to merge #1567 and then work on this.

Let's keep this issue open to track the work.

@ruffson
Copy link
Author

ruffson commented May 3, 2021

Awesome, thank you!

@davidhewitt davidhewitt mentioned this issue May 24, 2021
Closed
7 tasks
@davidhewitt davidhewitt mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pyclass: allow #[pyo3(get, set, name = "foo")] davidhewitt/pyo3
2 participants
@ruffson @davidhewitt