Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12 Release #1104

Closed
5 of 6 tasks
davidhewitt opened this issue Aug 13, 2020 · 8 comments · Fixed by #1173
Closed
5 of 6 tasks

0.12 Release #1104

davidhewitt opened this issue Aug 13, 2020 · 8 comments · Fixed by #1173

Comments

@davidhewitt
Copy link
Member

davidhewitt commented Aug 13, 2020

While the original issues I marked out for the 0.12 milestone are still not yet completed, I think that master already contains a lot of changes compared to 0.11.1.

So I'm tempted to suggest we push most of the outstanding issues from the 0.12 milestone into the 0.13 milestone (unless there is sudden movement on any of them) and start heading towards releasing 0.12. I think it doesn't really matter if the rest of the proposals don't land until 0.13.

This is what I still think should probably happen before an 0.12 release (as well as anything else people contribute):

Any thoughts?

@kngwyu
Copy link
Member

kngwyu commented Aug 14, 2020

I want to include the fix for #844. And we still need to conversion table though we have https://pyo3.rs/v0.11.1/conversions.html?

@davidhewitt
Copy link
Member Author

Thanks, I added that to my post.

For the doc table - yeah I think it's still a good idea. I'll probably open a PR about it over the weekend, and hopefully you'll see then that it's useful.

@kngwyu
Copy link
Member

kngwyu commented Aug 15, 2020

In addition, I also want to include some enum-related PRs (#1045 and #1065)

@davidhewitt
Copy link
Member Author

davidhewitt commented Aug 15, 2020

👍 it would be good to have #1045 and #1065, but if our contributors need more time to design these features I wouldn't think we have to wait for these to go in 0.12.

@mvaled
Copy link
Contributor

mvaled commented Aug 26, 2020

#844 can be checked.

@davidhewitt
Copy link
Member Author

Of the issues still remaining in the list at the top, it's mostly documentation waiting on me (including the PyErr PR, which is just waiting for me to add docs and test). I'm moving house in just under two weeks, so I definitely aim to get it all wrapped up ASAP before my life is swarmed by piles of packing boxes!

There's also #1045. @kngwyu / @stillinbeta what's your thoughts on the status of that PR? If you'd like more time on it, I'm thinking that we move it to the 0.13 milestone.

@davidhewitt
Copy link
Member Author

davidhewitt commented Sep 7, 2020

If I don't hear any objections, I will make the 0.12 release this week. I'll probably merge #1115 on Wednesday evening, and the only other piece we're waiting for is the change to add_function discussed in #1156

As soon as those two are in, I'll create a release PR.

@gilescope
Copy link
Contributor

gilescope commented Sep 11, 2020

Friend has one last tweak to add - to help pick up python in anaconda env: #1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants