Skip to content

Commit ec2053b

Browse files
committed
Revert pylint.Run's exit parameter to do_exit
This has been inadvertently changed several releases ago to ``do_exit``. Close #3533
1 parent 90d4215 commit ec2053b

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

ChangeLog

+6
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ Release date: TBA
1111

1212
Close #3527
1313

14+
* Revert pylint.Run's `exit` parameter to ``do_exit``
15+
16+
This has been inadvertently changed several releases ago to ``do_exit``.
17+
18+
Close #3533
19+
1420
What's New in Pylint 2.5.0?
1521
===========================
1622

pylint/lint/run.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,9 @@ class Run:
6666
def _return_one(*args): # pylint: disable=unused-argument
6767
return 1
6868

69-
def __init__(self, args, reporter=None, do_exit=True):
69+
def __init__(
70+
self, args, reporter=None, exit=True
71+
): # pylint: disable=redefined-builtin
7072
self._rcfile = None
7173
self._plugins = []
7274
self.verbose = None
@@ -337,7 +339,7 @@ def __init__(self, args, reporter=None, do_exit=True):
337339

338340
linter.check(args)
339341
score_value = linter.generate_reports()
340-
if do_exit:
342+
if exit:
341343
if linter.config.exit_zero:
342344
sys.exit(0)
343345
else:

tests/benchmark/test_baseline_benchmarks.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ def test_baseline_benchmark_j1_all_checks_single_file(self, benchmark):
286286
# Just 1 file, but all Checkers/Extensions
287287
fileinfos = [self.empty_filepath]
288288

289-
runner = benchmark(Run, fileinfos, reporter=Reporter(), do_exit=False)
289+
runner = benchmark(Run, fileinfos, reporter=Reporter(), exit=False)
290290
assert runner.linter.config.jobs == 1
291291
print("len(runner.linter._checkers)", len(runner.linter._checkers))
292292
assert len(runner.linter._checkers) > 1, "Should have more than 'master'"

tests/lint/unittest_lint.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ def test_load_plugin_command_line():
518518

519519
run = Run(
520520
["--load-plugins", "dummy_plugin", join(REGRTEST_DATA_DIR, "empty.py")],
521-
do_exit=False,
521+
exit=False,
522522
)
523523
assert (
524524
len([ch.name for ch in run.linter.get_checkers() if ch.name == "dummy_plugin"])
@@ -534,7 +534,7 @@ def test_load_plugin_config_file():
534534
config_path = join(REGRTEST_DATA_DIR, "dummy_plugin.rc")
535535

536536
run = Run(
537-
["--rcfile", config_path, join(REGRTEST_DATA_DIR, "empty.py")], do_exit=False,
537+
["--rcfile", config_path, join(REGRTEST_DATA_DIR, "empty.py")], exit=False,
538538
)
539539
assert (
540540
len([ch.name for ch in run.linter.get_checkers() if ch.name == "dummy_plugin"])
@@ -556,7 +556,7 @@ def test_load_plugin_configuration():
556556
"foo,bar",
557557
join(REGRTEST_DATA_DIR, "empty.py"),
558558
],
559-
do_exit=False,
559+
exit=False,
560560
)
561561
assert run.linter.config.black_list == ["foo", "bar", "bin"]
562562

0 commit comments

Comments
 (0)