From 69cc56ebe174b7f81bfad32fb5e6d3cf10f83718 Mon Sep 17 00:00:00 2001 From: Jessie Cai Date: Tue, 4 Jun 2024 13:36:24 -0400 Subject: [PATCH 1/6] Fixed PHP binPath for windows users --- bin/php-express/lib/PHPExpress/index.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/php-express/lib/PHPExpress/index.js b/bin/php-express/lib/PHPExpress/index.js index ace85011..91f76126 100644 --- a/bin/php-express/lib/PHPExpress/index.js +++ b/bin/php-express/lib/PHPExpress/index.js @@ -13,7 +13,10 @@ var PHPExpress = function (opts) { console.log(`Error was: ${error || stderr}`) process.exit(1); } else { - this.binPath = stdout.trim(); + const stdoutVal = stdout.trim(); + if (stdoutVal !== '') { + this.binPath = stdoutVal; + } console.log(`PHP found at ${this.binPath}`); } }); From 2ec0b8e13f61454104f3aafd19f581f14b907faf Mon Sep 17 00:00:00 2001 From: "josiah.williams" Date: Wed, 5 Jun 2024 10:03:37 -0400 Subject: [PATCH 2/6] test commit for readme file --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index ac07a84d..4bd64245 100755 --- a/README.md +++ b/README.md @@ -165,3 +165,5 @@ When testing using screen readers, these resources may be of help to you: - [Desktop Screen Readers Survival Guide - Basic Keyboard Shortcuts](https://dequeuniversity.com/screenreaders/survival-guide) - [NVDA Users Guide](https://www.nvaccess.org/files/nvda/documentation/userGuide.html) + +test commit \ No newline at end of file From 6e5640216f99b593864ee4e44a619111b7378694 Mon Sep 17 00:00:00 2001 From: "josiah.williams" Date: Wed, 5 Jun 2024 10:12:38 -0400 Subject: [PATCH 3/6] test commit for new github userid --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4bd64245..c066d866 100755 --- a/README.md +++ b/README.md @@ -166,4 +166,4 @@ When testing using screen readers, these resources may be of help to you: - [Desktop Screen Readers Survival Guide - Basic Keyboard Shortcuts](https://dequeuniversity.com/screenreaders/survival-guide) - [NVDA Users Guide](https://www.nvaccess.org/files/nvda/documentation/userGuide.html) -test commit \ No newline at end of file +test commit for github userid \ No newline at end of file From f0275bf6e9d3d048c6981ee712ec25aaedc2463e Mon Sep 17 00:00:00 2001 From: "josiah.williams" Date: Wed, 5 Jun 2024 10:18:43 -0400 Subject: [PATCH 4/6] Adding additional instructions for Java install --- README.md | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index c066d866..a76b66c9 100755 --- a/README.md +++ b/README.md @@ -28,6 +28,28 @@ A place to learn and share with developers what makes web work accessible. This - You can find the path to the installed PHP using `which php`. Add that path to your terminal profile's PATH environment value and/or VS Code settings. - Java: required in order to use the v.Nu checker during automation and unit testing + - Install options: + - ```bash + brew install java + ``` + - ```bash + brew install openjdk + ``` + - Additional tasks + + - ```bash + java -version + ``` + + If you get "Unable to locate a Java Runtime", proceed to next step. + + - Ensure your symlink is correctly mapped (these instructions will also appear after you brew install java) + + - ```bash + sudo ln -sfn /opt/homebrew/opt/openjdk/libexec/openjdk.jdk \ + /Library/Java/JavaVirtualMachines/openjdk.jdk + ``` + > Note: Any changes to these prerequisites will need to be reflected in the GitHub Actions in order to run the CI/CD checks. #### Optional installations (since `npm run server` will run an express server) @@ -165,5 +187,3 @@ When testing using screen readers, these resources may be of help to you: - [Desktop Screen Readers Survival Guide - Basic Keyboard Shortcuts](https://dequeuniversity.com/screenreaders/survival-guide) - [NVDA Users Guide](https://www.nvaccess.org/files/nvda/documentation/userGuide.html) - -test commit for github userid \ No newline at end of file From e3fe8b884e268a796a34bc4152e6f74b02f18f67 Mon Sep 17 00:00:00 2001 From: "josiah.williams" Date: Wed, 5 Jun 2024 10:49:11 -0400 Subject: [PATCH 5/6] Updates info for testing --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index a76b66c9..47ff611a 100755 --- a/README.md +++ b/README.md @@ -81,6 +81,8 @@ A place to learn and share with developers what makes web work accessible. This > See the [Chromedriver issues](#chromedriver-issues) section if you encounter an error related to Chromedriver. + > Make sure your server is running in another terminal before running `npm run test`. + ## Tests ### Tools used for testing From 384353020eb6df000a95462d5a62b8e93e3ebe38 Mon Sep 17 00:00:00 2001 From: "josiah.williams" Date: Wed, 5 Jun 2024 14:50:01 -0400 Subject: [PATCH 6/6] Updates Java install instructions. Clarifies local server for tests --- README.md | 41 ++++++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 47ff611a..c3e77062 100755 --- a/README.md +++ b/README.md @@ -29,26 +29,33 @@ A place to learn and share with developers what makes web work accessible. This - Java: required in order to use the v.Nu checker during automation and unit testing - Install options: - - ```bash - brew install java - ``` - - ```bash - brew install openjdk - ``` - - Additional tasks - - ```bash - java -version - ``` - - If you get "Unable to locate a Java Runtime", proceed to next step. - - - Ensure your symlink is correctly mapped (these instructions will also appear after you brew install java) + - Brew Install Options: - ```bash - sudo ln -sfn /opt/homebrew/opt/openjdk/libexec/openjdk.jdk \ - /Library/Java/JavaVirtualMachines/openjdk.jdk + brew install java ``` + - ```bash + brew install openjdk + ``` + - Additional tasks + + - ```bash + java -version + ``` + + If you get "Unable to locate a Java Runtime", proceed to next step. + + - Ensure your symlink is correctly mapped (these instructions will also appear after you brew install java) + + - ```bash + sudo ln -sfn /opt/homebrew/opt/openjdk/libexec/openjdk.jdk \ + /Library/Java/JavaVirtualMachines/openjdk.jdk + ``` + + - Manual Install Options: + - Mac Install + - Windows Install > Note: Any changes to these prerequisites will need to be reflected in the GitHub Actions in order to run the CI/CD checks. @@ -81,7 +88,7 @@ A place to learn and share with developers what makes web work accessible. This > See the [Chromedriver issues](#chromedriver-issues) section if you encounter an error related to Chromedriver. - > Make sure your server is running in another terminal before running `npm run test`. + > Make sure your local server is running in another terminal before running `npm run test`. ## Tests